planner, sessionctx : Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding #18017

Reminiscent · 2020-06-15T07:32:57Z

What problem does this PR solve?

Issue Number: close #16425

Problem Summary:
Add last_plan_from_binding to help know whether sql's plan is matched with the hints in the binding

What is changed and how it works?

What's Changed:

add a session scope system variable last_plan_from_binding to help decide whether the plan cache got hit.
display the last_plan_from_binding in slow log and statement summary table

Check List

Related changes

PR to update pingcap/docs/pingcap/docs-cn
Unit test
Integration test

Release note

Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding

…whether sql's plan is matched with the hints in the binding

…g in slow log

…ents_statements_summary_by_digest'

Reminiscent · 2020-06-15T08:48:02Z

@lawyerphx @eurekaka PTAL
It's similar to #16321, #16476 and #17088.

codecov · 2020-06-15T08:55:06Z

Codecov Report

Merging #18017 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #18017   +/-   ##
===========================================
  Coverage   79.5721%   79.5721%           
===========================================
  Files           526        526           
  Lines        143725     143725           
===========================================
  Hits         114365     114365           
  Misses        20175      20175           
  Partials       9185       9185

danmay319

rest LGTM

sessionctx/variable/session.go

Reminiscent · 2020-06-16T08:52:56Z

@lawyerphx @eurekaka PTAL

danmay319

LGTM

Reminiscent · 2020-06-18T02:58:53Z

/rebuild

sessionctx/variable/session.go

sessionctx/variable/tidb_vars.go

sessionctx/variable/session.go

zz-jason · 2020-11-12T04:50:57Z

infoschema/perfschema/const.go

@@ -415,6 +415,7 @@ const tableEventsStatementsSummaryByDigest = "CREATE TABLE if not exists perform
 	"LAST_SEEN timestamp(6) NOT NULL DEFAULT '0000-00-00 00:00:00.000000'," +
 	"PLAN_IN_CACHE bool NOT NULL," +
 	"PLAN_CACHE_HITS bigint unsigned NOT NULL," +
+	"PLAN_IN_SPM bool NOT NULL," +


Suggested change

"PLAN_IN_SPM bool NOT NULL," +

"PLAN_IN_BINDING bool NOT NULL," +

� Conflicts: � sessionctx/variable/varsutil.go

Reminiscent · 2020-11-16T07:53:41Z

@zz-jason Change all PLAN_IN_SPM to PLAN_IN_BINDING. PTAL

eurekaka

LGTM

eurekaka · 2020-11-20T09:09:28Z

@crazycs520 I suppose this change would not break slow query stuffs, please help confirm this.

eurekaka · 2020-11-20T09:18:00Z

/run-all-tests

Reminiscent · 2020-11-20T12:06:53Z

/run-all-tests

Reminiscent · 2020-11-20T12:18:50Z

/merge

ti-srebot · 2020-11-20T12:21:24Z

/run-all-tests

ti-srebot · 2020-11-20T12:32:21Z

@Reminiscent merge failed.

Reminiscent · 2020-11-20T12:32:47Z

/merge

ti-srebot · 2020-11-20T12:33:21Z

/run-all-tests

Reminiscent · 2020-12-02T06:49:30Z

/label needs-cherry-pick-4.0

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

ti-srebot · 2020-12-02T06:50:19Z

cherry pick to release-4.0 in PR #21430

…er sql's plan is matched with the hints in the binding (#18017) (#21430)

Reminiscent added 3 commits June 15, 2020 15:25

planner, sessionctx : Add 'last_statement_found_in_spm' to help know …

fda7a92

…whether sql's plan is matched with the hints in the binding

Merge branch 'master' of https://github.com/pingcap/tidb into issue16425

93a324d

sessionctx: record if a query is matched with the hints in the bindin…

a6b3b21

…g in slow log

github-actions bot added sig/execution SIG execution sig/planner SIG: Planner labels Jun 15, 2020

Reminiscent added 2 commits June 15, 2020 16:29

FIX UT

b9ce0cd

planner, infoschema : add columns about SPM in 'performance_schema.ev…

e6cd489

…ents_statements_summary_by_digest'

Reminiscent marked this pull request as ready for review June 15, 2020 08:48

github-actions bot added the sig/sql-infra SIG: SQL Infra label Jun 15, 2020

danmay319 reviewed Jun 16, 2020

View reviewed changes

sessionctx/variable/session.go Outdated Show resolved Hide resolved

address comment

b06c9e1

Reminiscent requested a review from danmay319 June 16, 2020 08:53

danmay319 added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2020

danmay319 reviewed Jun 16, 2020

View reviewed changes

address comment

ab95a38

Reminiscent requested review from a team as code owners June 18, 2020 03:11

Reminiscent requested review from wshwsh12 and removed request for a team June 18, 2020 03:11

zz-jason requested review from a team and removed request for a team June 18, 2020 03:15

zz-jason reviewed Jun 18, 2020

View reviewed changes

sessionctx/variable/session.go Outdated Show resolved Hide resolved

sessionctx/variable/tidb_vars.go Outdated Show resolved Hide resolved

qw4990 reviewed Jun 18, 2020

View reviewed changes

sessionctx/variable/session.go Outdated Show resolved Hide resolved

address comment

2e1e7ae

Reminiscent changed the title ~~planner, sessionctx : Add 'last_statement_found_in_spm' to help know whether sql's plan is matched with the hints in the binding~~ planner, sessionctx : Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding Jun 18, 2020

FIX UT

b0d4969

zz-jason reviewed Nov 12, 2020

View reviewed changes

Reminiscent added 4 commits November 16, 2020 15:38

Merge branch 'master' of https://github.com/pingcap/tidb into issue16425

950e9cf

� Conflicts: � sessionctx/variable/varsutil.go

address comments

98b78a8

fix test

3698b07

fix test

ee7770c

Reminiscent requested a review from zz-jason November 16, 2020 07:53

fix test

818f2db

eurekaka reviewed Nov 20, 2020

View reviewed changes

ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2020

ti-srebot approved these changes Nov 20, 2020

View reviewed changes

ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 20, 2020

Merge branch 'master' into issue16425

322f570

Merge branch 'master' into issue16425

87662d7

ti-srebot merged commit 2c66371 into pingcap:master Nov 20, 2020

ti-srebot added the needs-cherry-pick-4.0 label Dec 2, 2020

ti-srebot mentioned this pull request Dec 2, 2020

planner, sessionctx : Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding (#18017) #21430

Merged

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Dec 2, 2020

cherry pick pingcap#18017 to release-4.0

824d8f1

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

qw4990 pushed a commit that referenced this pull request Mar 12, 2021

planner, sessionctx : Add 'last_plan_from_binding' to help know wheth…

5edebf9

…er sql's plan is matched with the hints in the binding (#18017) (#21430)

Reminiscent deleted the issue16425 branch August 5, 2021 01:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

planner, sessionctx : Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding #18017

planner, sessionctx : Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding #18017

Reminiscent commented Jun 15, 2020 •

edited

Loading

Reminiscent commented Jun 15, 2020 •

edited

Loading

codecov bot commented Jun 15, 2020 •

edited

Loading

danmay319 left a comment

Reminiscent commented Jun 16, 2020

danmay319 left a comment

Reminiscent commented Jun 18, 2020

zz-jason Nov 12, 2020

Reminiscent commented Nov 16, 2020

eurekaka left a comment

eurekaka commented Nov 20, 2020

eurekaka commented Nov 20, 2020

Reminiscent commented Nov 20, 2020

Reminiscent commented Nov 20, 2020

ti-srebot commented Nov 20, 2020

ti-srebot commented Nov 20, 2020

Reminiscent commented Nov 20, 2020

ti-srebot commented Nov 20, 2020

Reminiscent commented Dec 2, 2020

ti-srebot commented Dec 2, 2020

	"PLAN_IN_SPM bool NOT NULL," +
	"PLAN_IN_BINDING bool NOT NULL," +

planner, sessionctx : Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding #18017

planner, sessionctx : Add 'last_plan_from_binding' to help know whether sql's plan is matched with the hints in the binding #18017

Conversation

Reminiscent commented Jun 15, 2020 • edited Loading

What problem does this PR solve?

What is changed and how it works?

Check List

Related changes

Release note

Reminiscent commented Jun 15, 2020 • edited Loading

codecov bot commented Jun 15, 2020 • edited Loading

Codecov Report

danmay319 left a comment

Choose a reason for hiding this comment

Reminiscent commented Jun 16, 2020

danmay319 left a comment

Choose a reason for hiding this comment

Reminiscent commented Jun 18, 2020

zz-jason Nov 12, 2020

Choose a reason for hiding this comment

Reminiscent commented Nov 16, 2020

eurekaka left a comment

Choose a reason for hiding this comment

eurekaka commented Nov 20, 2020

eurekaka commented Nov 20, 2020

Reminiscent commented Nov 20, 2020

Reminiscent commented Nov 20, 2020

ti-srebot commented Nov 20, 2020

ti-srebot commented Nov 20, 2020

Reminiscent commented Nov 20, 2020

ti-srebot commented Nov 20, 2020

Reminiscent commented Dec 2, 2020

ti-srebot commented Dec 2, 2020

Reminiscent commented Jun 15, 2020 •

edited

Loading

Reminiscent commented Jun 15, 2020 •

edited

Loading

codecov bot commented Jun 15, 2020 •

edited

Loading