executor: optimize the get snapshot table meta for tiflash/replica HTTP API #17969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TP API Signed-off-by: crazycs520 <crazycs520@gmail.com>
crazycs520
added
type/enhancement
tangenta
added
status/LGT2
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #17969 +/- ##
===========================================
Coverage 79.4551% 79.4551%
===========================================
Files 524 524
Lines 142065 142065
===========================================
Hits 112878 112878
Misses 20059 20059
Partials 9128 9128 |
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-3.1 in PR #18183 |
ti-srebot
pushed a commit
to ti-srebot/tidb
that referenced
this pull request
Jun 23, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #18184 |
zz-jason
pushed a commit
that referenced
this pull request
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: crazycs520 crazycs520@gmail.com
What problem does this PR solve?
backaground
/tiflash/replicaHTTP API needs to read the dropped or truncated table information with snapshot.Before this PR, TiDB will use
GetSnapshotInfoSchemato generate a snapshot information schema, then read the dropped or truncated table from this snapshot information.The problem is, if there are too many dropped/truncated DDL history jobs, and the GC life is too long, then query
/tiflash/replicaHTTP API will be very slow, the most of time is spent on the generate many snapshot information schema.This PR just use the schema ID and table ID to load the table information with snapshot, avoid the expensive generated snapshot information schema process.
Related changes
Check List
Tests
Side effects
Release note
optimize the get snapshot table meta for tiflash/replica HTTP API.