ddl: fix a bug that creating a table with set column don't handle collation correctly #17905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #17905 +/- ##
===========================================
Coverage 79.5755% 79.5755%
===========================================
Files 524 524
Lines 142995 142995
===========================================
Hits 113789 113789
Misses 20033 20033
Partials 9173 9173 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 10, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17924 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com
What problem does this PR solve?
Issue Number: close #17891
Problem Summary:
We didn't handle collation when setting the default value for set column.
What is changed and how it works?
Use the collation style to check default value.
Related changes
Check List
Tests
Side effects
Release note