-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: record execute runtime information in slow log #17573
Merged
Merged
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
9840c53
init
crazycs520 cec70da
Merge branch 'master' into slow-log-plan-info
crazycs520 cb3b2dd
fix test
crazycs520 1f993f5
Merge branch 'slow-log-plan-info' of https://github.com/crazycs520/ti…
crazycs520 1a7b7bc
add test1
crazycs520 5ca3ee8
add test2
crazycs520 90121f8
fix panic
crazycs520 73b1026
make test stable
crazycs520 0fc0940
Merge branch 'master' into slow-log-plan-info
crazycs520 aef298f
Merge branch 'master' into slow-log-plan-info
crazycs520 fd5aa68
Merge branch 'master' into slow-log-plan-info
crazycs520 cd1601b
try to fix test
crazycs520 d7dd02f
try to fix test race
crazycs520 8c86eaf
Merge branch 'master' into slow-log-plan-info
crazycs520 5b90223
Merge branch 'master' into slow-log-plan-info
crazycs520 2940cda
open collect runtime information to bench
crazycs520 45fe779
Merge branch 'master' into slow-log-plan-info
crazycs520 e3da540
Merge branch 'master' into slow-log-plan-info
crazycs520 31faa60
Merge branch 'master' into slow-log-plan-info
crazycs520 7ab3ee7
Merge branch 'master' into slow-log-plan-info
crazycs520 f045368
Merge branch 'master' into slow-log-plan-info
crazycs520 356c847
Merge branch 'master' into slow-log-plan-info
crazycs520 be51049
Merge branch 'master' into slow-log-plan-info
crazycs520 5bc8684
Merge branch 'master' into slow-log-plan-info
crazycs520 de40722
Merge branch 'master' into slow-log-plan-info
qw4990 be4b51b
close collect runtime information by default
crazycs520 e758b5c
Merge branch 'master' into slow-log-plan-info
crazycs520 d4a86d6
fix test
crazycs520 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about PhysicalIndexMergeReader?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just extract those code from
prepareOperatorInfo
, I'm not sure whether it is a bug.... @qw4990 PTALThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can ignore this problem here since it's another thing, the
PhysicalIndexMergeReader
doesn't support collecting read-stats now. @wjhuang2016 @crazycs520