Associate each region with an independent backoffer #17568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xintao <hunterlxt@live.com>
|
|
Codecov Report
@@ Coverage Diff @@
## master #17568 +/- ##
===========================================
Coverage 79.6747% 79.6747%
===========================================
Files 520 520
Lines 141469 141469
===========================================
Hits 112715 112715
Misses 19763 19763
Partials 8991 8991 |
|
cc @hicqu |
lzmhhh123
added
component/tikv
needs-cherry-pick-3.0
status/LGT1
Signed-off-by: Xintao <hunterlxt@live.com>
lysu
added
status/LGT2
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 2, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #17583 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 2, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #17584 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 2, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17585 |
sre-bot
added a commit
that referenced
this pull request
Jun 6, 2020
ti-srebot
added a commit
that referenced
this pull request
Jun 28, 2020
ti-srebot
pushed a commit
that referenced
this pull request
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xintao hunterlxt@live.com
What problem does this PR solve?
Issue Number: close tikv/tikv#7853
Problem Summary:
The backoffer of the boRegionMiss has a backoff mechanism with a starting time of 2ms and a maximum of 500ms. After log verification, a SQL command will share the same backoffer, that is, if multiple regions return epoch not match error, then the backoffer will quickly rise to 500ms. It is easy to exceed the preset time limit of 40s, causing SQL errors on the client.
What is changed and how it works?
What's Changed: Add a function to get Backoffer
How it Works: Use a Map to store backoffer with specific region id
Related changes
Check List
Tests
Before this PR, the SQL usually returns
region is unavailableSide effects
No
Release note
Backofferfor each region to avoid the SQL command timeout issue when multiple region requests fail at the same time