Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metrics: enlarge upper limits of some duration metrics #17451

Merged
merged 8 commits into from
Jun 3, 2020

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented May 27, 2020

What problem does this PR solve?

Issue Number:
close #17450

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • No release note

jackysp added 3 commits May 27, 2020 13:23
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp changed the title Enlarge duration metrics: enlarge duration upper limit May 27, 2020
@jackysp jackysp changed the title metrics: enlarge duration upper limit metrics: enlarge upper limits of some duration metrics May 27, 2020
@jackysp jackysp requested review from coocood and lysu May 27, 2020 07:31
@jackysp
Copy link
Member Author

jackysp commented May 27, 2020

/run-monitor-test

@sre-bot
Copy link
Contributor

sre-bot commented May 27, 2020

Visit the grafana server at: http://172.16.5.5:32184, it will last for 5 hours

@jackysp
Copy link
Member Author

jackysp commented Jun 1, 2020

PTAL @lysu @coocood

@coocood
Copy link
Member

coocood commented Jun 1, 2020

LGTM

Copy link

@imtbkcat imtbkcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp
Copy link
Member Author

jackysp commented Jun 2, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 2, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Jun 2, 2020

Your auto merge job has been accepted, waiting for:

  • 17582

@sre-bot
Copy link
Contributor

sre-bot commented Jun 2, 2020

/run-all-tests

@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Jun 2, 2020
@zz-jason
Copy link
Member

zz-jason commented Jun 2, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 2, 2020

Your auto merge job has been accepted, waiting for:

  • 17490
  • 17368
  • 17516

@sre-bot
Copy link
Contributor

sre-bot commented Jun 2, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 2, 2020

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Jun 3, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

Your auto merge job has been accepted, waiting for:

  • 17516

@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

@jackysp merge failed.

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #17451 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #17451   +/-   ##
===========================================
  Coverage   79.5477%   79.5477%           
===========================================
  Files           520        520           
  Lines        140273     140273           
===========================================
  Hits         111584     111584           
  Misses        19738      19738           
  Partials       8951       8951           

@jackysp
Copy link
Member Author

jackysp commented Jun 3, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

Your auto merge job has been accepted, waiting for:

  • 17640
  • 17452

@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

@jackysp merge failed.

@jackysp
Copy link
Member Author

jackysp commented Jun 3, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

/run-all-tests

@sre-bot sre-bot merged commit 9929068 into pingcap:master Jun 3, 2020
sre-bot pushed a commit to sre-bot/tidb that referenced this pull request Jun 3, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot
Copy link
Contributor

sre-bot commented Jun 3, 2020

cherry pick to release-4.0 in PR #17648

sre-bot added a commit that referenced this pull request Jun 6, 2020
* cherry pick #17451 to release-4.0

Signed-off-by: sre-bot <sre-bot@pingcap.com>

* resolve conflicts

Signed-off-by: Shuaipeng Yu <jackysp@gmail.com>

Co-authored-by: Jack Yu <yusp@pingcap.com>
Co-authored-by: Shuaipeng Yu <jackysp@gmail.com>
@jackysp jackysp deleted the enlarge_duration branch November 25, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/metrics status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enlarge the upper limits of some metrics
6 participants