Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/admin: support admin cleanup index on the partition table (#17203) #17405

Merged
merged 2 commits into from
May 26, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented May 26, 2020

cherry-pick #17203 to release-4.0


Signed-off-by: crazycs520 crazycs520@gmail.com

What problem does this PR solve?

Before this PR, admin cleanup index won't take effect on partition table.

What is changed and how it works?

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test

Side effects

  • No

Release note

  • support admin cleanup index on the partition table

Signed-off-by: sre-bot <sre-bot@pingcap.com>
@sre-bot sre-bot requested a review from a team as a code owner May 26, 2020 05:17
@sre-bot
Copy link
Contributor Author

sre-bot commented May 26, 2020

/run-all-tests

@ghost ghost requested a review from XuHuaiyu May 26, 2020 05:17
@sre-bot sre-bot added sig/execution SIG execution type/4.0-cherry-pick type/bugfix This PR fixes a bug. labels May 26, 2020
@ghost ghost removed their request for review May 26, 2020 05:17
@sre-bot sre-bot added this to the v4.0.0-ga milestone May 26, 2020
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@tiancaiamao
Copy link
Contributor

LGTM

@crazycs520
Copy link
Contributor

/run-all-tests

@tiancaiamao tiancaiamao added the status/LGT1 Indicates that a PR has LGTM 1. label May 26, 2020
@crazycs520
Copy link
Contributor

/run-all-tests

@jebter
Copy link

jebter commented May 26, 2020

@bb7133 PTAL

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jebter
Copy link

jebter commented May 26, 2020

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 26, 2020
@sre-bot
Copy link
Contributor Author

sre-bot commented May 26, 2020

/run-all-tests

@sre-bot
Copy link
Contributor Author

sre-bot commented May 26, 2020

@sre-bot merge failed.

@jebter
Copy link

jebter commented May 26, 2020

/run-all-tests

@jebter jebter merged commit 82592df into pingcap:release-4.0 May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants