prometheus push metrics #1733
Merged
prometheus push metrics #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
zimulala
reviewed
Sep 18, 2016
| logFile = flag.String("log-file", "", "log file path") | ||
| joinCon = flag.Int("join-concurrency", 5, "the number of goroutines that participate joining.") | ||
| metricsAddr = flag.String("metrics-addr", "", "prometheus pushgateway address, leaves it empty will disable prometheus.") | ||
| metricsInterval = flag.String("metrics-interval", "0s", "prometheus client push interval, set \"0s\" to disable prometheus.") |
There was a problem hiding this comment.
Use metricsInterval and metricsInterval.
There was a problem hiding this comment.
not disable prometheus, but push.
|
@zimulala PTAL |
|
LGTM |
overvenus
reviewed
Sep 18, 2016
| } | ||
| log.Info("start Prometheus push client") | ||
| // TODO: TiDB do not have uniq name, so we use host+port to compose a name. | ||
| name := fmt.Sprintf("TiDB-%s:%s", *host, *port) |
There was a problem hiding this comment.
TiKV uses TiKV_1, I think it better be to "TiDB_%s:%s".
|
@overvenus PTAL |
|
LGTM |
1 similar comment
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@coocood @siddontang PTAL
Refer: tikv/pd#325