decide push down conditions during plan building phase. #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenli
reviewed
Sep 17, 2016
| @@ -40,6 +41,7 @@ type PhysicalIndexScan struct { | |||
|
|
|||
| accessEqualCount int | |||
| AccessCondition []expression.Expression | |||
| ConditionPBExpr *tipb.Expr | |||
There was a problem hiding this comment.
Add comment for the newly added attribute.
shenli
reviewed
Sep 17, 2016
| "github.com/pingcap/tipb/go-tipb" | ||
| ) | ||
|
|
||
| func expressionsToPB(exprs []expression.Expression, client kv.Client) (pbExpr *tipb.Expr, remained []expression.Expression, err error) { |
There was a problem hiding this comment.
Should we remove the code related to expressionToPB in executor package?
There was a problem hiding this comment.
yes, we should. But currently we can't, because we still need convert agg function to pb.
|
Rest LGTM |
|
LGTM |
1 similar comment
|
LGTM |
zimulala
reviewed
Sep 18, 2016
| client := txn.GetClient() | ||
| var memDB bool | ||
| switch p.DBName.L { | ||
| case "information_schema", "performance_schema": |
There was a problem hiding this comment.
This pr has been merged ... , btw , this code is ported from executor.go
There was a problem hiding this comment.
welcome to review #1730 and leave your suggestion :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shenli @coocood @zimulala @tiancaiamao @XuHuaiyu PTAL