store/tikv: do not send batch commands to tiflash (#17282) #17307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: pingcap-github-bot <sre-bot@pingcap.com>
|
/run-all-tests |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #17282 to release-4.0
What problem does this PR solve?
Problem Summary:
After set @@global.tidb_allow_batch_cop = true and send query to tiflash; Sometimes it will report TiKV server timeout error. Observing the tidb log, it has many ["receive a grpc cancel signal from remote"] [error="rpc error: code = Canceled desc = grpc: the client connection is closing"].
It's because client_batch.go will recycle "idle" connection, but TiFlash request does not use client_batch request, its connection is deleted by mistake.
What's Changed:
After discussion, we decide not to send batch commands to tiflash
Tests
Side effects
This is not a important feature fot tiflash, so it has no side effects
Release note