expression: support collation for REGEXP function #17255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
Codecov Report
@@ Coverage Diff @@
## master #17255 +/- ##
===========================================
Coverage 79.7429% 79.7429%
===========================================
Files 522 522
Lines 142133 142133
===========================================
Hits 113341 113341
Misses 19780 19780
Partials 9012 9012 |
wshwsh12
reviewed
May 28, 2020
qw4990
added
status/can-merge
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/merge |
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/merge |
|
/run-all-tests |
|
@wjhuang2016 merge failed. |
|
/run-unit-test |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Jun 2, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-4.0 in PR #17581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #17094
Problem Summary:
Previously, we didn't handle collation when builds the REGEXP function.
What is changed and how it works?
If the collation is case-insensitive, we compile it by
regexp.Compile("(?i)" + pat).If not, we compile it by
regexp.CompileRelated changes
Check List
Tests
Side effects
Release note