kv: fix transaction too large error message #17198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobotu
added
type/enhancement
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #17198 +/- ##
===========================================
Coverage 79.9887% 79.9887%
===========================================
Files 511 511
Lines 139202 139202
===========================================
Hits 111346 111346
Misses 18889 18889
Partials 8967 8967 |
jackysp
reviewed
May 14, 2020
bobotu
changed the title
Pushed a new commit, just change the error message. PTAL @jackysp |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for:
|
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
/run-all-tests |
|
@bobotu merge failed. |
|
/rebuild |
|
/merge |
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #17219 |
sre-bot
added a commit
that referenced
this pull request
May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The size hint in
TxnTooLarge's message is the size limit of the staging buffer.It is hard to understand.
What is changed and how it works?
Use the
TxnTotalSizeLimitto generate error message.Release note
Transaction is too largeeasier to understand.