*: use EncodeRowKeyWithHandle to generate endKey

executor/executor_xapi.go

@@ -124,7 +124,7 @@ func tableHandlesToKVRanges(tid int64, handles []int64) []kv.KeyRange {
 			continue
 		}
 		startKey := tablecodec.EncodeRowKeyWithHandle(tid, h)
-		endKey := startKey.PrefixNext()
+		endKey := tablecodec.EncodeRowKeyWithHandle(tid, h+1)
 		krs = append(krs, kv.KeyRange{StartKey: startKey, EndKey: endKey})
 	}
 	return krs

tablecodec/bench_test.go

@@ -0,0 +1,41 @@
+// Copyright 2016 PingCAP, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package tablecodec
+
+import (
+	"testing"
+)
+
+func BenchmarkEncodeRowKeyWithHandle(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		EncodeRowKeyWithHandle(100, 100)
+	}
+}
+
+func BenchmarkEncodeEndKey(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		EncodeRowKeyWithHandle(100, 100)
+		EncodeRowKeyWithHandle(100, 101)
+	}
+}
+
+// PrefixNext() is slow than using EncodeRowKeyWithHandle.
+// BenchmarkEncodeEndKey-4		20000000	        97.2 ns/op
+// BenchmarkEncodeRowKeyWithPrefixNex-4	10000000	       121 ns/op
+func BenchmarkEncodeRowKeyWithPrefixNex(b *testing.B) {
+	for i := 0; i < b.N; i++ {
+		sk := EncodeRowKeyWithHandle(100, 100)
+		sk.PrefixNext()
+	}
+}