Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support auto_random table option (#16750) #16812

Merged
merged 7 commits into from
Apr 26, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Apr 24, 2020

cherry-pick #16750 to release-3.1


What problem does this PR solve?

Problem Summary: support auto_random_base table option

the conflict file is in:
1: `tables.go` function `RebaseAutoID`, interface Allocators is not cherry-picked. So change it to Allocator
2: `builder.go` lack of diff.type parameter.
3:  also fix a bug in `show.go` & `show_test.go`, the comment should be `/*T![auto_rand_base] xxx */`, I will do the same on the master soon

What is changed and how it works?

How it Works:
After this table option:
We can do the auto_random rebase by alter table xxx auto_random_base = num
Also we can specify the initial auto_random base by create table t xxx(xxx) auto_random_base = num

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

support auto_random table option for rebase auto_random allocator

@sre-bot
Copy link
Contributor Author

sre-bot commented Apr 24, 2020

/run-all-tests

@AilinKid
Copy link
Contributor

don't worry, the releated parser hasn't been cherry-picked, wait for a while

@AilinKid
Copy link
Contributor

the linked parser is in pingcap/parser#830

@bb7133 bb7133 added the priority/release-blocker This issue blocks a release. Please solve it ASAP. label Apr 26, 2020
@AilinKid AilinKid force-pushed the release-3.1-7b25ce0d948d branch from eb69793 to f6eb817 Compare April 26, 2020 03:02
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2020
Copy link
Contributor

@djshow832 djshow832 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid
Copy link
Contributor

/run-all-tests

@AilinKid AilinKid added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2020
@AilinKid
Copy link
Contributor

/run-common-test

@AilinKid
Copy link
Contributor

/run-mybatis-test

@AilinKid
Copy link
Contributor

/build

@bb7133 bb7133 closed this Apr 26, 2020
@bb7133 bb7133 reopened this Apr 26, 2020
@AilinKid
Copy link
Contributor

AilinKid commented Apr 26, 2020

reopen can trigger it to run again? @bb7133

@bb7133 bb7133 merged commit 489b077 into pingcap:release-3.1 Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/3.1-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants