executor, infoschema, util: add sum_errors and sum_warnings to statement summary tables #16456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
github-actions
bot
added
sig/sql-infra
Codecov Report
@@ Coverage Diff @@
## master #16456 +/- ##
===========================================
Coverage 80.3601% 80.3601%
===========================================
Files 506 506
Lines 136605 136605
===========================================
Hits 109776 109776
Misses 18244 18244
Partials 8585 8585 |
…w832/tidb into stmt_summary_runtime_error
|
/run-unit-test |
Deardrops
reviewed
Apr 16, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@djshow832 merge failed. |
|
/run-integration-copr-test |
|
/run-unit-test |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 17, 2020
…ent summary tables (pingcap#16456)
|
cherry pick to release-4.0 in PR #16502 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Add
sum_errorsandsum_warningstostatements_summary.These 2 fields indicate the total errors and warnings encountered for each kind of SQL.
What is changed and how it works?
What's Changed:
ONLY summarize runtime errors now. It's a big move to also consider compiler errors, so it's not suitable for 4.0.
MySQL: Statements that has parser errors are not summarized in statement summary tables.
TiDB: Statements that has parser errors or compiler errors are not summarized.
How it Works:
Error: check whether it succeeded.
Warning: get
StmtCtx.WarningCount().Related changes
pingcap/docs/pingcap/docs-cn:Check List
Tests
Side effects
N/A
Release note
sum_errorsandsum_warningsto statement summary tables.