Set ServerStatusInTrans flag #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| // SetStatusInTrans sets the status flags about ServerStatusInTrans. | ||
| func (s *SessionVars) SetStatusInTrans(isInTrans bool) { | ||
| if isInTrans { | ||
| s.Status = s.Status | mysql.ServerStatusInTrans |
| @@ -513,6 +513,45 @@ func (s *testSessionSuite) TestAutoicommit(c *C) { | |||
| mustExecSQL(c, se, s.dropDBSQL) | |||
| } | |||
|
|
|||
| func checkInTrans(c *C, se Session, stmt string, isNil bool, expect uint16) { | |||
There was a problem hiding this comment.
Seems no need to use expect or isNil variable? Use one of them is enough?
|
When we begined a transaction, then executed an DDL statement, that transaction is force commited, so the server status in transaction should be set to false. |
|
got it, my fault. |
|
LGTM |
1 similar comment
|
LGTM |
YuJuncen
pushed a commit
to YuJuncen/tidb
that referenced
this pull request
Apr 23, 2021
…gcap#158 (pingcap#159) * tests: fix a test failure due to conflict between pingcap#145 and pingcap#158 * restore: apply the row count limit to failpoint KillIfImportedChunk too
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Sep 28, 2021
xhebox
pushed a commit
to xhebox/tidb
that referenced
this pull request
Oct 8, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
Oct 9, 2021
nolouch
pushed a commit
to tidblabs/tidb
that referenced
this pull request
Jan 6, 2023
* release 6.4 support tiflash multi-tenant Signed-off-by: iosmanthus <myosmanthustree@gmail.com> * fix make check Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Signed-off-by: iosmanthus <myosmanthustree@gmail.com> Co-authored-by: David <8039876+AmoebaProtozoa@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.