*: move hint and block hint processor to util directory #15897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eurekaka
added
type/enhancement
ghost
requested review from
XuHuaiyu and
winoros
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #15897 +/- ##
================================================
- Coverage 80.5573% 80.4090% -0.1484%
================================================
Files 505 505
Lines 135347 135006 -341
================================================
- Hits 109032 108557 -475
- Misses 17836 17940 +104
- Partials 8479 8509 +30 |
qw4990
added
status/can-merge
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #15900 |
eurekaka
added a commit
to sre-bot/tidb
that referenced
this pull request
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Not a problem, just move code around. Split from #15895.
What is changed and how it works?
What's Changed:
Move code related to
hintProcessorandBlockHintProcessortoutil/hint/directory, because I want to use them in #15895, otherwise, I would have import cycle.How it Works:
Related changes
Check List
Tests
Side effects
N/A
Release note