config: remove txn-local-latches from config file #15765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PTAL @jackysp |
jackysp
reviewed
Mar 27, 2020
| @@ -77,7 +77,7 @@ type Config struct { | |||
| MemQuotaQuery int64 `toml:"mem-quota-query" json:"mem-quota-query"` | |||
| EnableStreaming bool `toml:"enable-streaming" json:"enable-streaming"` | |||
| EnableBatchDML bool `toml:"enable-batch-dml" json:"enable-batch-dml"` | |||
| TxnLocalLatches TxnLocalLatches `toml:"txn-local-latches" json:"txn-local-latches"` | |||
| TxnLocalLatches TxnLocalLatches `toml:"-" json:"-"` | |||
There was a problem hiding this comment.
Will it make -config-check fail? Maybe we need to add it to
Line 675 in 7a67ff4
Codecov Report
@@ Coverage Diff @@
## master #15765 +/- ##
===========================================
Coverage 80.4465% 80.4465%
===========================================
Files 504 504
Lines 134692 134692
===========================================
Hits 108355 108355
Misses 17862 17862
Partials 8475 8475 |
|
LGTM |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@bobotu merge failed. |
|
/run-all-tests |
|
/run-unit-test |
|
/merge |
|
/run-all-tests |
|
@bobotu merge failed. |
|
/run-all-tests |
|
/merge |
|
/run-all-tests |
|
@bobotu merge failed. |
|
/merge |
|
/run-all-tests |
|
cherry pick to release-4.0 in PR #15792 |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #17079 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
May 11, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.1 in PR #17080 |
13 tasks
This was referenced Jun 8, 2022
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
The
txn-local-latchesmay lack sufficient tests and not recommend to use for now.fix #15746
What is changed and how it works?
Omitting
txn-local-latcheswhen marshal/unmarshals config file and make it disabled by default.Tests