planner: add warning when the table name of indexHint cannot be found (#15517) #15762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
/run-all-tests |
sre-bot
added
sig/planner
|
/run-unit-test |
zz-jason
reviewed
Mar 31, 2020
…lease-3.1-dd141728a329 # Conflicts: # planner/core/testdata/integration_suite_in.json # planner/core/testdata/integration_suite_out.json
|
@zz-jason, @eurekaka, @XuHuaiyu, @lzmhhh123, PTAL. |
1 similar comment
|
@zz-jason, @eurekaka, @XuHuaiyu, @lzmhhh123, PTAL. |
|
@sre-bot, please update your pull request. |
|
@zz-jason, @eurekaka, @XuHuaiyu, @lzmhhh123, PTAL. |
|
PTAL @zz-jason @lzmhhh123 |
lzmhhh123
reviewed
Apr 13, 2020
Comment on lines
31
to
53
| { | ||
| "name": "TestReadFromStorageHint", | ||
| "cases": [ | ||
| "desc select avg(a) from t", | ||
| "desc select /*+ read_from_storage(tiflash[t]) */ avg(a) from t", | ||
| "desc select /*+ read_from_storage(tiflash[t]) */ sum(a) from t", | ||
| "desc select /*+ read_from_storage(tiflash[t]) */ sum(a+1) from t", | ||
| "desc select /*+ read_from_storage(tiflash[t]) */ sum(isnull(a)) from t", | ||
| "desc select * from tt where (tt.a > 1 and tt.a < 20) or (tt.a >= 30 and tt.a < 55)", | ||
| "desc select /*+ read_from_storage(tiflash[tt]) */ * from tt where (tt.a > 1 and tt.a < 20) or (tt.a >= 30 and tt.a < 55)", | ||
| "desc select * from ttt order by ttt.a desc", | ||
| "desc select /*+ read_from_storage(tiflash[ttt]) */ * from ttt order by ttt.a desc", | ||
| "desc select /*+ read_from_storage(tiflash[ttt]) */ * from ttt order by ttt.a" | ||
| ] | ||
| }, | ||
| { | ||
| "name": "TestReadFromStorageHintAndIsolationRead", | ||
| "cases": [ | ||
| "desc select /*+ read_from_storage(tikv[t], tiflash[t]) */ avg(a) from t", | ||
| "desc select /*+ read_from_storage(tikv[t]) */ avg(a) from t", | ||
| "desc select /*+ read_from_storage(tiflash[t]) */ avg(a) from t" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
These tests have been involved in integration_serial_suite_in.json. Is it correct to re-present here?
There was a problem hiding this comment.
Yeah, that's a mistake. I have removed them in the latest commit. PTAL
zz-jason
added
status/can-merge
|
/run-all-tests |
1 similar comment
|
/run-all-tests |
|
@sre-bot merge failed. |
|
/run-integration-common-test |
|
/run-integration-common-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15517 to release-3.1
What problem does this PR solve?
Problem Summary:
Throw a warning when the index hint is not applicable(i.e. cannot find the table).
What is changed and how it works?
What's Changed:
Before this PR:
After this PR:
How it Works:
Check if there are unused tableHints after building the select statement.
Check List
Tests