Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Add --log-file flag to set log file path #1560

Merged
merged 3 commits into from
Aug 8, 2016
Merged

*: Add --log-file flag to set log file path #1560

merged 3 commits into from
Aug 8, 2016

Conversation

shenli
Copy link
Member

@shenli shenli commented Aug 7, 2016

@coocood
Copy link
Member

coocood commented Aug 7, 2016

LGTM

1 similar comment
@c4pt0r
Copy link
Member

c4pt0r commented Aug 7, 2016

LGTM

@@ -75,7 +75,18 @@ func main() {
ReportStatus: *reportStatus,
}

// Set log options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add . or Set -> set

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL @zimulala

@zimulala
Copy link
Contributor

zimulala commented Aug 8, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants