-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
planner: forbiden nested view creation (#15420) #15424
Merged
zz-jason
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-0c5e58107dad
Mar 26, 2020
Merged
planner: forbiden nested view creation (#15420) #15424
zz-jason
merged 3 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-0c5e58107dad
Mar 26, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
sre-bot
added
sig/execution
SIG execution
sig/planner
SIG: Planner
type/3.0-cherry-pick
type/bugfix
This PR fixes a bug.
labels
Mar 17, 2020
qw4990
reviewed
Mar 17, 2020
/run-all-tests |
SunRunAway
reviewed
Mar 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
approved these changes
Mar 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
zz-jason
added
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
and removed
status/LGT1
Indicates that a PR has LGTM 1.
labels
Mar 26, 2020
Your auto merge job has been accepted, waiting for 15635, 15711, 15512 |
/run-all-tests |
@sre-bot merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/execution
SIG execution
sig/planner
SIG: Planner
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/bugfix
This PR fixes a bug.
type/3.0-cherry-pick
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #15420 to release-3.0
What problem does this PR solve?
Problem Summary:
Before this commit, nested view creation is allowed in TiDB, while select on this view brings panic. Actually, nested view creation is forbidden in MySQL.
What is changed and how it works?
What's Changed:
Check the underlying views of when creating a view. And make the error message be compatible with MySQL.
How it Works:
Forbid creating view nested.
Related changes
release-3.0, release-3.1, release-4.0
Check List
Tests
Side effects
N/A
Release note