Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix the data race on TestDataForTableStatsField and TestPartitionsTable #15260

Merged
merged 14 commits into from
Mar 10, 2020
Merged

executor: fix the data race on TestDataForTableStatsField and TestPartitionsTable #15260

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
9b9ee76
fix CI
reafans Mar 10, 2020
3062bc7
Merge branch 'master' into fix_CI
reafans Mar 10, 2020
b0f0e90
fix bug
reafans Mar 10, 2020
0ecca82
Merge branch 'fix_CI' of https://github.com/reafans/tidb into fix_CI
reafans Mar 10, 2020
52dd649
fix bug
reafans Mar 10, 2020
c94e512
fix bug
reafans Mar 10, 2020
ca11edb
Merge branch 'master' into fix_CI
reafans Mar 10, 2020
5f21812
add SerialSuites for bug test
reafans Mar 10, 2020
d8330c8
Merge branch 'fix_CI' of https://github.com/reafans/tidb into fix_CI
reafans Mar 10, 2020
d4c4965
fmt
reafans Mar 10, 2020
d1af41d
Merge branch 'master' into fix_CI
reafans Mar 10, 2020
4468c7b
add defer unlock and comment
reafans Mar 10, 2020
812e804
Merge branch 'fix_CI' of https://github.com/reafans/tidb into fix_CI
reafans Mar 10, 2020
59095f7
add RWMutex for cache
reafans Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fmt
  • Loading branch information
@reafans
reafans committed Mar 10, 2020
commit d4c496536fc43749ffe964acf61624e399276e0c
3 changes: 2 additions & 1 deletion executor/infoschema_reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,13 @@
package executor_test

import (
"github.com/pingcap/tidb/executor"
"strconv"

. "github.com/pingcap/check"
"github.com/pingcap/parser/auth"
"github.com/pingcap/tidb/config"
"github.com/pingcap/tidb/domain"
"github.com/pingcap/tidb/executor"
"github.com/pingcap/tidb/kv"
"github.com/pingcap/tidb/statistics/handle"
"github.com/pingcap/tidb/util/testkit"
Expand Down Expand Up @@ -285,6 +285,7 @@ func (s *testInfoschemaTableSerialSuite) TestDataForTableStatsField(c *C) {
}

func (s *testInfoschemaTableSerialSuite) TestPartitionsTable(c *C) {
s.dom.SetStatsUpdating(true)
oldExpiryTime := executor.TableStatsCacheExpiry
executor.TableStatsCacheExpiry = 0
defer func() { executor.TableStatsCacheExpiry = oldExpiryTime }()
Expand Down