-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: add builtin function json_storage_size
#15248
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15248 +/- ##
===========================================
Coverage ? 80.2706%
===========================================
Files ? 503
Lines ? 132554
Branches ? 0
===========================================
Hits ? 106402
Misses ? 17748
Partials ? 8404 |
@stoksc Thanks for your contribution, we will review this PR soon~ |
Thanks, could you add some tests like https://dev.mysql.com/doc/refman/8.0/en/json-utility-functions.html#function_json-storage-size? |
Added it to the above tests section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Your auto merge job has been accepted, waiting for 14920 |
/run-all-tests |
What problem does this PR solve?
close #14488
What is changed and how it works?
Add a builtin function for
json_storage_size
. My only concern is if the length of the marshaled json is correct as the storage size.Tests
Added unit tests, as well as this local manual test: