-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util/codec: add EncodedBytesLength #15170
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15170 +/- ##
================================================
- Coverage 80.4183% 80.2408% -0.1776%
================================================
Files 502 503 +1
Lines 133324 132303 -1021
================================================
- Hits 107217 106161 -1056
- Misses 17692 17746 +54
+ Partials 8415 8396 -19 |
9c61323
to
9767072
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zhiqiangxu please also update these two places to use this function. |
Applied to these two places. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
This helper function can be used in
encodeHashDataKey
,encodeHashMetaKey
etc, to estimate the key size more accurately.