Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor,infoschema: move dataForUserPrivileges from infoschema to executor #15155

Merged

Conversation

Rustin170506
Copy link
Member

@Rustin170506 Rustin170506 commented Mar 5, 2020

UCP #15038

Signed-off-by: Rustin-Liu rustin.liu@gmail.com

What problem does this PR solve?

#15038

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported variable/fields change
  • Has persistent data change

Side effects

None

Related changes

None

Release note

None

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Mar 5, 2020
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #15155 into master will not change coverage by %.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #15155   +/-   ##
===========================================
  Coverage   80.3304%   80.3304%           
===========================================
  Files           503        503           
  Lines        133074     133074           
===========================================
  Hits         106899     106899           
  Misses        17780      17780           
  Partials       8395       8395           

@Rustin170506
Copy link
Member Author

@sre-bot /run-all-tests

1 similar comment
@Rustin170506
Copy link
Member Author

@sre-bot /run-all-tests

@Rustin170506
Copy link
Member Author

@sre-bot /coverage

@Rustin170506 Rustin170506 marked this pull request as ready for review March 5, 2020 13:47
@zz-jason zz-jason added the sig/execution SIG execution label Mar 5, 2020
@reafans
Copy link
Contributor

reafans commented Mar 6, 2020

lgtm

@reafans reafans added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 6, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 6, 2020

Thanks for your contribution. If your PR get merged, you will be rewarded 50 points.

…o `executor`

Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 force-pushed the rustin-patch-dataForUserPrivileges branch from 766fae7 to 1beeff5 Compare March 6, 2020 08:20
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@Rustin170506
Copy link
Member Author

Rustin170506 commented Mar 6, 2020

@lonng @zz-jason PTAL~

@Rustin170506
Copy link
Member Author

@sre-bot /run-all-tests

Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
@Rustin170506 Rustin170506 requested a review from a team as a code owner March 6, 2020 09:45
@ghost ghost requested review from SunRunAway and XuHuaiyu and removed request for a team March 6, 2020 09:45
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 6, 2020
@zz-jason zz-jason added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 6, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 6, 2020

/run-all-tests

@sre-bot sre-bot merged commit 5d0a260 into pingcap:master Mar 6, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Mar 6, 2020

Congratulation! You have awarded a badge for usability challenge program! Please fill the form to get your reward! http://tidbcommunity.mikecrm.com/QMCv4QL

@sre-bot
Copy link
Contributor

sre-bot commented Mar 6, 2020

Team Rustin-Liu complete task #15038 and get 50 score, currerent score 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/execution SIG execution status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants