-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: add a channel to limit multiple DDL jobs writing at the same time (#14342) #15148
Merged
zimulala
merged 7 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-6ccdf645dc7b
Mar 11, 2020
Merged
ddl: add a channel to limit multiple DDL jobs writing at the same time (#14342) #15148
zimulala
merged 7 commits into
pingcap:release-3.0
from
sre-bot:release-3.0-6ccdf645dc7b
Mar 11, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sre-bot <sre-bot@pingcap.com>
/run-all-tests |
djshow832
reviewed
Mar 5, 2020
AilinKid
reviewed
Mar 5, 2020
b2cb293
to
40a73d5
Compare
PTAL @djshow832 @AilinKid |
djshow832
reviewed
Mar 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AilinKid
previously approved these changes
Mar 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
@sre-bot merge failed. |
/run-integration-ddl-test |
/run-all-tests |
AilinKid
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
sig/sql-infra
SIG: SQL Infra
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
type/enhancement
The issue or PR belongs to an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #14342 to release-3.0
What problem does this PR solve?
When performing DDL operations on multiple connections at the same time, you may encounter a "Write conflict" error.
What is changed and how it works?
Adding a channel on a single TiDB to limit multiple DDL jobs writing to the DDL job list at the same time results in "Write conflict".
Check List
Tests
WC is the error of
write confilct
.Related changes
Release note