store: check constraint for "Delete-Your-Writes" records when txn commit #14968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lysu
added
type/bugfix
|
need merge pingcap/kvproto#565 first to let CI happy and tikv will be handle by tikv/tikv#6715 |
This was referenced Feb 27, 2020
coocood
reviewed
Feb 28, 2020
|
/run-all-tests tikv=pr/6715 |
|
check_dev_2 fail due to it only run with tikv master by design, it should be green after kv pr merged. |
|
LGTM |
youjiali1995
reviewed
Mar 3, 2020
Codecov Report
@@ Coverage Diff @@
## master #14968 +/- ##
===========================================
Coverage 80.4098% 80.4098%
===========================================
Files 503 503
Lines 133011 133011
===========================================
Hits 106954 106954
Misses 17679 17679
Partials 8378 8378 |
|
/rebuild |
|
/run-all-tests |
|
/run-unit-test |
youjiali1995
approved these changes
Mar 6, 2020
youjiali1995
added
status/LGT2
|
/merge |
sre-bot
added
the
status/can-merge
|
Your auto merge job has been accepted, waiting for 14816 |
|
/run-all-tests |
|
@lysu merge failed. |
|
/merge |
|
Your auto merge job has been accepted, waiting for 15172 |
|
/run-all-tests |
|
@lysu merge failed. |
|
/merge |
|
/run-all-tests |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Mar 6, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-3.0 in PR #15176 |
sre-bot
added a commit
that referenced
this pull request
Mar 11, 2020
qw4990
pushed a commit
to qw4990/tidb
that referenced
this pull request
May 28, 2020
This was referenced Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
in #9127, we push constraint check down to tikv layer when prewrite phase.
but it miss the situation that txn add record a then delete record a, we also need check record is real duplicate when commit.
so just as
TestDeferConstraintCheckForDelete, it will lead to "delete wrong data"(primary key) or "inconsist index data"(unique key)What is changed and how it works?
we can do a addition batch get check for those key before commit just like pre-#9127 logic
but maybe better to follow #9127's idea just check it with prewrite mutation flag.
Check List
Tests
Code changes
Side effects
Related changes
Release note
This change is