Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: show cast type in EXPLAIN #14942

Merged
merged 7 commits into from
Feb 26, 2020

Conversation

gauss1314
Copy link
Contributor

What problem does this PR solve?

This fix #14916 .
Show cast type in EXPLAIN.

Check List

Tests

  • Unit test

Signed-off-by: gauss <gauss1314@gmail.com>
@gauss1314 gauss1314 requested review from a team as code owners February 25, 2020 13:53
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Feb 25, 2020
@ghost ghost requested review from eurekaka and alivxxx and removed request for a team February 25, 2020 13:54
Signed-off-by: gauss <gauss1314@gmail.com>
Signed-off-by: gauss <gauss1314@gmail.com>
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@f4674b1). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #14942   +/-   ##
===========================================
  Coverage          ?   80.4256%           
===========================================
  Files             ?        503           
  Lines             ?     132035           
  Branches          ?          0           
===========================================
  Hits              ?     106190           
  Misses            ?      17492           
  Partials          ?       8353

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francis0407
Copy link
Member

/run-all-tests

@francis0407 francis0407 added sig/planner SIG: Planner type/enhancement The issue or PR belongs to an enhancement. labels Feb 26, 2020
@francis0407
Copy link
Member

/run-all-tests tidb-test=pr/995

@francis0407
Copy link
Member

/run-all-tests tidb-test=pr/995

Copy link
Member

@francis0407 francis0407 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Feb 26, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 26, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 26, 2020

@gauss1314 merge failed.

@francis0407
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Feb 26, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 26, 2020

@gauss1314 merge failed.

@francis0407
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Feb 26, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 26, 2020

@gauss1314 merge failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. sig/planner SIG: Planner status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

planner: show cast type in EXPLAIN
6 participants