Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: add a check to reject changing some config items during runtime #14830

Merged
merged 11 commits into from
Feb 20, 2020
Merged

config: add a check to reject changing some config items during runtime #14830

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
716ab22
Add dynamic config item list
qw4990 Feb 18, 2020
9765406
Merge remote-tracking branch 'upstream/master' into allowed-config-list
qw4990 Feb 18, 2020
46a1fa2
add comments
qw4990 Feb 18, 2020
226a5af
format
qw4990 Feb 18, 2020
835593b
Merge remote-tracking branch 'upstream/master' into allowed-config-list
qw4990 Feb 20, 2020
f6d5dc2
address comments
qw4990 Feb 20, 2020
d77e9b5
address comments
qw4990 Feb 20, 2020
18d7f95
Merge remote-tracking branch 'upstream/master' into allowed-config-list
qw4990 Feb 20, 2020
f16d307
fix conflict
qw4990 Feb 20, 2020
fa2b841
address comments
qw4990 Feb 20, 2020
fd365bf
address comments
qw4990 Feb 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add comments
  • Loading branch information
@qw4990
qw4990 committed Feb 18, 2020
commit 46a1fa2947a3b28e1ced8f0374d0482f35dad764
1 change: 1 addition & 0 deletions config/config_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ func CloneConf(conf *Config) (*Config, error) {
}

var (
// dynamicConfigItems contains all config items that can be changed during runtime.
dynamicConfigItems = []string{
"Performance.MaxProcs", "Performance.MaxMemory",
"Performance.CrossJoin", "Performance.FeedbackProbability",
Expand Down