*: add auto_random id cache for statement retrying and table recover #14711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bb7133
reviewed
Feb 10, 2020
|
|
||
| func (r *retryInfoAutoIDs) next() (int64, error) { | ||
| if r.currentOffset >= len(r.autoIDs) { | ||
| return 0, errCantGetValidID |
There was a problem hiding this comment.
The error message of errCantGetValidID is "cannot get valid auto-increment id in retry". I suggest to modify it to "Cannot get a valid auto-ID when retrying the statement", what do you think?
AilinKid
reviewed
Feb 10, 2020
sessionctx/variable/session.go
Outdated
|
|
||
| // AddAutoIncrementID adds id to autoIncrementIDs. | ||
| func (r *RetryInfo) AddAutoIncrementID(id int64) { | ||
| r.autoIncrementIDs.add(id) |
There was a problem hiding this comment.
I think should be directly r.autoRandomIDs.autoIDs = append(r.autoRandomIDs.autoIDs, id) here.
AddAutoIncrementID()->add()->append() may be too deep.
crazycs520
reviewed
Feb 11, 2020
|
/run-check_dev_2 |
crazycs520
reviewed
Feb 11, 2020
reafans
reviewed
Feb 12, 2020
reafans
reviewed
Feb 12, 2020
reafans
reviewed
Feb 12, 2020
|
lgtm |
bb7133
added
status/LGT2
|
should resolve the conflict. |
AilinKid
added
status/LGT3
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@tangenta merge failed. |
|
/run-unit-test |
|
/merge |
|
/run-all-tests |
tangenta
added a commit
to tangenta/tidb
that referenced
this pull request
Mar 16, 2020
sre-bot
pushed a commit
that referenced
this pull request
Mar 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This is a patch for #13127.
What is changed and how it works?
Add retry and recover table cache support for
auto_random.Check List
Tests
Code changes
Side effects
Related changes
Release note