planner: reset plan id before optimizing point get (#14471) #14595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed, PTAL |
Addressed, PTAL again. |
eurekaka
approved these changes
Feb 3, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conflicting files:
planner/core/point_get_plan_test.goWhat problem does this PR solve?
Plan id is reset before optimization every time, so that ids of operators are the same when physical plans are the same.
But when the plan is a point get, the plan id is not reset, leading to different ids of
PointGet, so plan digests are different.If the plan digest are different, statement summary can't work properly. Refer to issue #14432
What is changed and how it works?
Reset plan id before
tryFastPlanand add test cases.Check List
Tests
Code changes
N/A
Side effects
Related changes
N/A
Release note