bindinfo: set default db for bindings correctly #14077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
removed their request for review
Codecov Report
@@ Coverage Diff @@
## master #14077 +/- ##
===========================================
Coverage ? 80.1799%
===========================================
Files ? 482
Lines ? 120953
Branches ? 0
===========================================
Hits ? 96980
Misses ? 16237
Partials ? 7736 |
eurekaka
added
status/can-merge
|
/run-all-tests |
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Jan 20, 2020
sre-bot
pushed a commit
that referenced
this pull request
Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
For bindings like
select * from test.t, it should be used in every db, not only the db that created it.What is changed and how it works?
For sqls that have no implicit databases, we set the default db to empty, so it can be used regardless of current db.
Check List
Tests
Code changes
Side effects
Related changes
Release note