ddl: add index progress metric #14055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
eurekaka and
winoros
and removed request for
a team
crazycs520
commented
Dec 13, 2019
ddl/ddl_worker.go
Outdated
| @@ -69,6 +70,7 @@ type worker struct { | |||
| quitCh chan struct{} | |||
| wg sync.WaitGroup | |||
|
|
|||
| statsHandle unsafe.Pointer | |||
There was a problem hiding this comment.
Use domain to get statsHandle will have a circle import problem. So stay the statsHandle in DDL worker.
Codecov Report
@@ Coverage Diff @@
## master #14055 +/- ##
===========================================
Coverage ? 80.2878%
===========================================
Files ? 483
Lines ? 122209
Branches ? 0
===========================================
Hits ? 98119
Misses ? 16300
Partials ? 7790 |
alivxxx
reviewed
Dec 16, 2019
AilinKid
reviewed
Dec 16, 2019
|
@lamxTyler @AilinKid PTAL |
|
can we change the progress from [0, 1] to [0, 100]? |
|
/run-all-tests |
bb7133
reviewed
Dec 19, 2019
bb7133
reviewed
Dec 19, 2019
bb7133
added
status/LGT3
bb7133
added
the
status/can-merge
|
/run-all-tests |
|
/run-all-tests |
|
@crazycs520 merge failed. |
|
/run-all-tests |
|
/run-integration-copr-test |
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
It indicates the progress of the current add index job. Since we not support concurrently add multi-index jobs now, it will be ok now.
The add index progress = (added row count) / (total row count) *100.
To avoid use
select count(*)to get the total count of the table, It use the table count from statistics, It doesn't matter since it uses to estimate the progress.related pr: pingcap/tidb-ansible#1064
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note