config: forbid user to set TxnTotalSizeLimit too large with binlog enabled
#14006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enabled When the large transaction is enabled, the Prewrite and Commit message would be too large for the binlog component to handle, so it's better to prevent that case.
tiancaiamao
added
type/enhancement
Codecov Report
@@ Coverage Diff @@
## master #14006 +/- ##
===========================================
Coverage 80.3077% 80.3077%
===========================================
Files 482 482
Lines 121469 121469
===========================================
Hits 97549 97549
Misses 16214 16214
Partials 7706 7706 |
|
LGTM |
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
When the large transaction is enabled, the Prewrite and Commit message would be
too large for the binlog component to handle, so it's better to prevent that case.
What is changed and how it works?
Update
config.Valid()function to check it.Check List
Tests