Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: fix static check issues #13878

Merged
merged 2 commits into from
Dec 28, 2019
Merged

server: fix static check issues #13878

merged 2 commits into from
Dec 28, 2019

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

#13736

What is changed and how it works?

Check List

Tests

None

Code changes

None

Side effects

None

Related changes

None

Release note

None

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 3, 2019
ngaut
ngaut approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 3, 2019
@codecov
Copy link

codecov bot commented Dec 3, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@2a4bd92). Click here to learn what that means.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master     #13878   +/-   ##
===========================================
  Coverage          ?   80.1187%           
===========================================
  Files             ?        474           
  Lines             ?     116597           
  Branches          ?          0           
===========================================
  Hits              ?      93416           
  Misses            ?      15802           
  Partials          ?       7379

@Rustin170506
Copy link
Member Author

PTAL~

1 similar comment
@Rustin170506
Copy link
Member Author

PTAL~

@Rustin170506
Copy link
Member Author

ping~

1 similar comment
@Rustin170506
Copy link
Member Author

ping~

zz-jason
zz-jason approved these changes Dec 28, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 28, 2019

Your auto merge job has been accepted, waiting for 13443, 14258

@sre-bot
Copy link
Contributor

sre-bot commented Dec 28, 2019

/run-all-tests

@sre-bot sre-bot merged commit 1d2377f into pingcap:master Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason approved these changes

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rustin170506 @sre-bot @ngaut @zz-jason