Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix contributors url link #13862

Merged
merged 4 commits into from
Dec 5, 2019
Merged

fix contributors url link #13862

merged 4 commits into from
Dec 5, 2019

Conversation

tptpp
Copy link
Contributor

@tptpp tptpp commented Dec 3, 2019

What problem does this PR solve?

#13861

What is changed and how it works?

fix the url link of contributors

Check List

Tests

  • No code

Related changes

  • Need to update the documentation

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 3, 2019
ngaut
ngaut approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 4, 2019
@codecov
Copy link

codecov bot commented Dec 4, 2019 •
edited
Loading

Codecov Report

Merging #13862 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13862   +/-   ##
===========================================
  Coverage   80.1993%   80.1993%           
===========================================
  Files           480        480           
  Lines        119107     119107           
===========================================
  Hits          95523      95523           
  Misses        16067      16067           
  Partials       7517       7517

wjhuang2016
wjhuang2016 reviewed Dec 5, 2019
View reviewed changes
Copy link
Member

@wjhuang2016 wjhuang2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjhuang2016 wjhuang2016 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 5, 2019
@ngaut ngaut merged commit 73ab6d8 into pingcap:master Dec 5, 2019
@bb7133
Copy link
Member

bb7133 commented Dec 6, 2019

@tptpp Thanks for contributing! BTW next time you can use the "close syntax" to close the related issue automatically when this PR is merged.

@bb7133 bb7133 mentioned this pull request Dec 6, 2019
Closed
@tptpp
Copy link
Contributor Author

tptpp commented Dec 6, 2019

@bb7133 Ok. Thanks for reminder

@tptpp tptpp deleted the fix_contributor_link branch December 6, 2019 08:49
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@tptpp @XiaTianliang
fix contributors url link (pingcap#13862)
9f283bf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjhuang2016 wjhuang2016 wjhuang2016 left review comments

@ngaut ngaut ngaut approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tptpp @bb7133 @ngaut @wjhuang2016 @sre-bot