Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinLocateBinary3ArgsSig #13809

Merged
merged 5 commits into from
Dec 4, 2019
Merged

expression: implement vectorized evaluation for builtinLocateBinary3ArgsSig #13809

merged 5 commits into from
Dec 4, 2019

Conversation

b41sh
Copy link
Member

@b41sh b41sh commented Nov 28, 2019

Signed-off-by: baishen baishen2009@gmail.com

What problem does this PR solve?

Implement vectorized evaluation for builtinLocateBinary3ArgsSig.
12106

What is changed and how it works?

goos: darwin
goarch: amd64
pkg: github.com/pingcap/tidb/expression
BenchmarkVectorizedBuiltinStringFunc/builtinLocateBinary3ArgsSig-VecBuiltinFunc-4         	   85585	     13222 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinLocateBinary3ArgsSig-NonVecBuiltinFunc-4      	   19460	     78087 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinLocateBinary3ArgsSig-VecBuiltinFunc#01-4      	   62563	     16759 ns/op	       0 B/op	       0 allocs/op
BenchmarkVectorizedBuiltinStringFunc/builtinLocateBinary3ArgsSig-NonVecBuiltinFunc#01-4   	   10000	    131020 ns/op	       0 B/op	       0 allocs/op

Check List

Tests

  • Unit test
  • Integration test

b41sh added 2 commits November 28, 2019 23:25
@b41sh
add builtinLocateBinary3ArgsSig
41141a8 
Signed-off-by: baishen <baishen2009@gmail.com>
@b41sh
optimize
590d70b 
Signed-off-by: baishen <baishen2009@gmail.com>
@b41sh b41sh requested a review from a team as a code owner November 28, 2019 15:40
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 28, 2019
@ghost ghost requested review from qw4990 and wshwsh12 and removed request for a team November 28, 2019 15:41
@codecov
Copy link

codecov bot commented Dec 2, 2019 •
edited
Loading

Codecov Report

Merging #13809 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master    #13809   +/-   ##
=========================================
  Coverage   80.323%   80.323%           
=========================================
  Files          479       479           
  Lines       119109    119109           
=========================================
  Hits         95672     95672           
  Misses       15910     15910           
  Partials      7527      7527

wshwsh12
wshwsh12 reviewed Dec 4, 2019
View reviewed changes
Copy link
Contributor

@wshwsh12 wshwsh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wshwsh12 wshwsh12 added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 4, 2019
qw4990
qw4990 approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990 qw4990 added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 4, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2019

Your auto merge job has been accepted, waiting for 13820, 13875

@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Dec 4, 2019

@b41sh merge failed.

@qw4990
Copy link
Contributor

qw4990 commented Dec 4, 2019

/run-all-tests

@qw4990
Copy link
Contributor

qw4990 commented Dec 4, 2019

/run-unit-test

@qw4990 qw4990 merged commit d2f23cd into pingcap:master Dec 4, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@b41sh @XiaTianliang
expression: implement vectorized evaluation for `builtinLocateBinary3…
a678982 
…ArgsSig` (pingcap#13809)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wshwsh12 wshwsh12 wshwsh12 left review comments

@qw4990 qw4990 qw4990 approved these changes

Assignees
No one assigned
Labels
component/expression contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@b41sh @sre-bot @qw4990 @wshwsh12 @zz-jason