Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

structure: refactor the code to add explicit type for const #13789

Merged
merged 3 commits into from
Nov 28, 2019
Merged

structure: refactor the code to add explicit type for const #13789

merged 3 commits into from
Nov 28, 2019

Conversation

Rustin170506
Copy link
Member

What problem does this PR solve?

#13736

What is changed and how it works?

Check List

Tests

None

Code changes

None

Side effects

None

Related changes

None

Release note

None

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 27, 2019
tangenta
tangenta reviewed Nov 27, 2019
View reviewed changes
Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta tangenta added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 27, 2019
jackysp
jackysp approved these changes Nov 28, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 28, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 28, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 28, 2019

@Rustin-Liu merge failed.

@codecov
Copy link

codecov bot commented Nov 28, 2019 •
edited
Loading

Codecov Report

Merging #13789 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13789   +/-   ##
===========================================
  Coverage   80.1195%   80.1195%           
===========================================
  Files           474        474           
  Lines        116813     116813           
===========================================
  Hits          93590      93590           
  Misses        15842      15842           
  Partials       7381       7381

@Rustin170506
Copy link
Member Author

@sre-bot /run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 28, 2019

/ /run-all-tests

@Rustin170506
Copy link
Member Author

@sre-bot /run-auto-merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 28, 2019

/

@Rustin170506
Copy link
Member Author

@sre-bot /run-auto-merge//merge

@sre-bot
Copy link
Contributor

sre-bot commented Nov 28, 2019

/ /

@ngaut ngaut added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 28, 2019
@ngaut ngaut merged commit 870ac75 into pingcap:master Nov 28, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@rustin-bot @XiaTianliang
structure: refactor the code to add explicit type for const (pingcap#…
e542404 
…13789)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta left review comments

@jackysp jackysp jackysp approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rustin170506 @sre-bot @jackysp @tangenta @ngaut @rustin-bot