types: Fix potential timezone related bugs caused by gotime.Local
#13752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #13752 +/- ##
===========================================
Coverage 80.2792% 80.2792%
===========================================
Files 474 474
Lines 117810 117810
===========================================
Hits 94577 94577
Misses 15799 15799
Partials 7434 7434 |
|
Thanks for your contribution, before your PR merge, please add some tests. |
Rustin170506
force-pushed
the
time-patch
branch
from
555815d to
15197bd
Compare
|
LGTM, @bb7133 PTAL |
bb7133
reviewed
Nov 27, 2019
bb7133
added
status/LGT2
bb7133
added
the
status/can-merge
|
/run-all-tests |
|
cherry pick to release-2.1 in PR #13792 |
|
cherry pick to release-3.0 in PR #13793 |
|
Thanks for your help! @Rustin-Liu |
bb7133
pushed a commit
that referenced
this pull request
Nov 28, 2019
bb7133
pushed a commit
that referenced
this pull request
Nov 28, 2019
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#13626
What is changed and how it works?
Use sc.TimeZone to create time variable when we round time in RoundFrac.
Check List
Tests
None
Code changes
None
Side effects
None
Related changes
None
Release note
None