expression: support expression reverse evaluation framework #13738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
qw4990 and
wshwsh12
and removed request for
a team
alivxxx
reviewed
Nov 26, 2019
expression/column.go
Outdated
|
|
||
| // ReverseEvalDuration evaluates the only one column duration value with given function result. | ||
| func (col *Column) ReverseEvalDuration(res types.Datum, rType RoundingType) (val types.Duration, err error) { | ||
| return res.GetMysqlDuration(), errors.Errorf("Constant.ReverseEvalDuration() should never be called, please contact the TiDB team for help") |
There was a problem hiding this comment.
Why return error for them?
lzmhhh123
force-pushed
the
dev/support_reverse_evaluation_framework
branch
from
f07c752 to
e8de681
Compare
Codecov Report
@@ Coverage Diff @@
## master #13738 +/- ##
===========================================
Coverage 80.3523% 80.3523%
===========================================
Files 480 480
Lines 119699 119699
===========================================
Hits 96181 96181
Misses 16007 16007
Partials 7511 7511 |
lzmhhh123
force-pushed
the
dev/support_reverse_evaluation_framework
branch
from
3e841bd to
bae37fd
Compare
alivxxx
reviewed
Nov 27, 2019
lzmhhh123
force-pushed
the
dev/support_reverse_evaluation_framework
branch
from
8b5de09 to
185f2e9
Compare
alivxxx
reviewed
Nov 29, 2019
alivxxx
reviewed
Dec 2, 2019
qw4990
reviewed
Dec 4, 2019
qw4990
reviewed
Dec 4, 2019
qw4990
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 13827 |
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
A sub PR of #13659
Now, we only support reverse evaluation for expression type
int,float,decimal. Because other types' reverse evaluations are very complex.What is changed and how it works?
Add the framework of the reverse evaluation for expression.
Check List
Tests
Code changes
Side effects