Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: the quote function should treat null expr as NULL literal string instead of NULL (#11592) #13681

Merged
merged 4 commits into from
Nov 26, 2019
Merged

expression: the quote function should treat null expr as NULL literal string instead of NULL (#11592) #13681

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
211d45a
expression: the quote func for null arg should map to "NULL" string
gaoxingliang Aug 2, 2019
fe2f252
expression: the quote func for null arg should map to "NULL" string (…
gaoxingliang Aug 2, 2019
419d3da
expression: the quote func for null arg should map to "NULL" string (…
gaoxingliang Aug 2, 2019
487b3bd
Merge branch 'release-2.1' into automated-cherry-pick-of-#11592-upstr…
sre-bot Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
expression: the quote func for null arg should map to "NULL" string (#… 
…11556)
  • Loading branch information
@gaoxingliang @SunRunAway
gaoxingliang authored and SunRunAway committed Nov 22, 2019
commit 419d3da66118620ed417887318ffa74cfbb749ad
2 changes: 1 addition & 1 deletion expression/builtin_string.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2668,7 +2668,7 @@ func (b *builtinQuoteSig) evalString(row chunk.Row) (string, bool, error) {
if err != nil {
return "", true, err
} else if isNull {
// If the argument is NULL, the return value is the word “NULL” without enclosing single quotation marks.
// If the argument is NULL, the return value is the word "NULL" without enclosing single quotation marks. see ref.
return "NULL", false, err
}

Expand Down