Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: refine error code for package meta #13654

Merged
merged 16 commits into from
Nov 27, 2019

Conversation

Deardrops
Copy link
Contributor

What problem does this PR solve?

Not all the errors in meta package have error code.

What is changed and how it works?

add them.

Check List

Tests

  • None

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

  • None

@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

Thanks for your PR.
This PR will be closed by bot because you already had 3 opened PRs, close or merge them before submitting a new one.
#12550 , #13168 , #13637

@codecov
Copy link

codecov bot commented Nov 21, 2019

Codecov Report

Merging #13654 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13654   +/-   ##
===========================================
  Coverage   80.0683%   80.0683%           
===========================================
  Files           474        474           
  Lines        116734     116734           
===========================================
  Hits          93467      93467           
  Misses        15882      15882           
  Partials       7385       7385

@Deardrops Deardrops added type/enhancement The issue or PR belongs to an enhancement. status/PTAL and removed closed/no-pr-quota labels Nov 21, 2019
@Deardrops Deardrops reopened this Nov 21, 2019
@Deardrops Deardrops marked this pull request as ready for review November 21, 2019 05:29
@Deardrops
Copy link
Contributor Author

/run-all-tests

@Deardrops
Copy link
Contributor Author

/run-all-tests

meta/meta.go Outdated Show resolved Hide resolved
meta/meta.go Outdated Show resolved Hide resolved
@Deardrops
Copy link
Contributor Author

/run-unit-test

meta/meta_test.go Outdated Show resolved Hide resolved
@Deardrops
Copy link
Contributor Author

/run-all-tests

domain/domain_test.go Outdated Show resolved Hide resolved
@@ -290,6 +294,7 @@ func (s *testSuite) TestSnapshot(c *C) {
c.Assert(n, Equals, int64(1))
_, err = snapMeta.GenGlobalID()
c.Assert(err, NotNil)
c.Assert(err.Error(), Equals, "[structure:5]write on snapshot")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an unexported error, so we check it by compare string.

@Deardrops
Copy link
Contributor Author

/run-all-tests

zimulala
zimulala previously approved these changes Nov 26, 2019
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala dismissed their stale review November 26, 2019 10:55

Miss a LGTM

@zimulala zimulala added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2019
@Deardrops
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Deardrops Deardrops added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 27, 2019
@Deardrops Deardrops merged commit 246b91e into pingcap:master Nov 27, 2019
qw4990 pushed a commit to qw4990/tidb that referenced this pull request Nov 27, 2019
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants