Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed staticcheck errors in folder cmd #13636

Merged
merged 3 commits into from
Nov 21, 2019
Merged

fixed staticcheck errors in folder cmd #13636

merged 3 commits into from
Nov 21, 2019

Conversation

hsqlu
Copy link
Contributor

@hsqlu hsqlu commented Nov 20, 2019 •
edited
Loading

What problem does this PR solve? #13456

Fixed the staticcheck errors in folder cmd

What is changed and how it works?

Advised by checks of staticcheck

Tests

  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change

Side effects

Related changes

Release note

Nothing

@sre-bot sre-bot added the contribution This PR is from a community contributor. label Nov 20, 2019
@codecov
Copy link

codecov bot commented Nov 20, 2019 •
edited
Loading

Codecov Report

Merging #13636 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #13636   +/-   ##
===========================================
  Coverage   79.9197%   79.9197%           
===========================================
  Files           473        473           
  Lines        115890     115890           
===========================================
  Hits          92619      92619           
  Misses        15973      15973           
  Partials       7298       7298

ngaut
ngaut approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@ngaut ngaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngaut ngaut added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 20, 2019
zimulala
zimulala approved these changes Nov 21, 2019
View reviewed changes
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 21, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 21, 2019

/run-all-tests

@sre-bot sre-bot merged commit 9a2c5e6 into pingcap:master Nov 21, 2019
@hsqlu hsqlu deleted the staticcheck-error-fix branch November 21, 2019 20:23
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@hsqlu @XiaTianliang
fixed staticcheck errors in folder cmd (pingcap#13636)
981481e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngaut ngaut ngaut approved these changes

@zimulala zimulala zimulala approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsqlu @sre-bot @ngaut @zimulala