test: optimize dll test #13497
Merged
test: optimize dll test #13497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #13497 +/- ##
================================================
- Coverage 80.2375% 80.2267% -0.0109%
================================================
Files 472 472
Lines 114328 114245 -83
================================================
- Hits 91734 91655 -79
+ Misses 15430 15421 -9
- Partials 7164 7169 +5 |
|
@zimulala PTAL |
|
/run-unit-tests |
zimulala
reviewed
Nov 15, 2019
zimulala
reviewed
Nov 15, 2019
glorv
force-pushed
the
ddl-test
branch
2 times, most recently
from
c83a6c5 to
4394a93
Compare
zz-jason
added
status/can-merge
|
Your auto merge job has been accepted, waiting for 13511 |
Codecov Report
@@ Coverage Diff @@
## master #13497 +/- ##
===========================================
Coverage 80.5384% 80.5384%
===========================================
Files 472 472
Lines 115895 115895
===========================================
Hits 93340 93340
Misses 15362 15362
Partials 7193 7193 |
|
/run-all-tests |
bb7133
added
status/LGT3
XiaTianliang
pushed a commit
to XiaTianliang/tidb
that referenced
this pull request
Dec 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
make ddl unit test running faster
What is changed and how it works?
One loop in the hot path cost almost 10s to execute, and several test cases depends on this function. The loop run 100 times to randomly select a range of 3 to check whether the result is right, this is unneccssary. We can reduce it to 20 times with check the lower/upper boundary and some random inner case is enough to make sure the logic is right.
Here is the result:
Before change:
After change:
Check List
Tests
Code changes
Side effects
Related changes