-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
executor: fix a batch get executor bug inside a transaction #13473
Conversation
When the BatchGetExec runs inside a transaction, it should consider the data changes in the membuffer.
Codecov Report
@@ Coverage Diff @@
## master #13473 +/- ##
================================================
- Coverage 80.3601% 80.2144% -0.1458%
================================================
Files 472 472
Lines 114772 114245 -527
================================================
- Hits 92231 91641 -590
- Misses 15387 15434 +47
- Partials 7154 7170 +16 |
/run-integration-copr-test |
d87d69d
to
9ea4a14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
LGTM |
/run-all-tests |
cherry pick to release-3.0 failed |
@@ -1445,7 +1445,7 @@ func iterateSnapshotRows(store kv.Storage, priority int, t table.Table, version | |||
ver := kv.Version{Ver: version} | |||
|
|||
snap, err := store.GetSnapshot(ver) | |||
snap.SetPriority(priority) | |||
snap.SetOption(kv.Priority, priority) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change relative to the bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change can save many lines of code.
…13473) When the BatchGetExec runs inside a transaction, it should consider the data changes in the membuffer.
What problem does this PR solve?
What is changed and how it works?
When the BatchGetExec runs inside a transaction, it should consider the data changes
in the membuffer.
Check List
Tests
Release note