Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: implement vectorized evaluation for builtinNowWithArgSig #13372

Merged
merged 6 commits into from
Nov 12, 2019
Merged

expression: implement vectorized evaluation for builtinNowWithArgSig #13372

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f13f47b
expression: implement vectorized evaluation for builtinNowWithArgSig
ekalinin Nov 11, 2019
3ad0772
expression: builtinNowWithArgSig, fixes after review
ekalinin Nov 12, 2019
afe2df6
Merge branch 'master' into vec-builtinNowWithArgSig
ekalinin Nov 12, 2019
bd856b8
Merge branch 'master' into vec-builtinNowWithArgSig
ekalinin Nov 12, 2019
108e21f
Merge branch 'master' into vec-builtinNowWithArgSig
ekalinin Nov 12, 2019
7515cff
Merge branch 'master' into vec-builtinNowWithArgSig
sre-bot Nov 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
expression: builtinNowWithArgSig, fixes after review
  • Loading branch information
@ekalinin
ekalinin committed Nov 12, 2019
commit 3ad0772fb0a9dcb19da5f8b93799ee2f903008ae
16 changes: 10 additions & 6 deletions expression/builtin_time_vec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,26 +578,30 @@ func (b *builtinNowWithArgSig) vecEvalTime(input *chunk.Chunk, result *chunk.Col
}

result.ResizeTime(n, false)
result.MergeNulls(bufFsp)
times := result.Times()
fsps := bufFsp.Int64s()

for i := 0; i < n; i++ {
fsp := int8(0)
if !result.IsNull(i) {
if !bufFsp.IsNull(i) {
if fsps[i] > int64(types.MaxFsp) {
return errors.Errorf("Too-big precision %v specified for 'now'. Maximum is %v.", fsps[i], types.MaxFsp)
}
if fsps[i] < int64(types.MinFsp) {
return errors.Errorf("Invalid negative %d specified, must in [0, 6].", fsps[i])
}
fsp = int8(fsps[i])
}

t, isNull, err := evalNowWithFsp(b.ctx, fsp)
if err != nil {
return err
}
if isNull {
result.SetNull(i, true)
continue
}

if err != nil {
return err
}

times[i] = t
}
return nil
Expand Down