expression: add setPbCode for Sign Sqrt #13336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
SunRunAway and
XuHuaiyu
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #13336 +/- ##
===========================================
Coverage 80.1242% 80.1242%
===========================================
Files 469 469
Lines 112348 112348
===========================================
Hits 90018 90018
Misses 15342 15342
Partials 6988 6988 |
SunRunAway
requested review from
andylokandy and
breezewish
and removed request for
SunRunAway and
XuHuaiyu
|
Hi, I think you need to fix the PbCode like #12864 instead of enable the push down here. |
Signed-off-by: Fullstop000 <fullstop1005@gmail.com>
Fullstop000
force-pushed
the
push_down_sqrt
branch
from
814f345 to
710b1d2
Compare
Fullstop000
changed the title
breezewish
approved these changes
Nov 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relate to tikv/tikv#5839
Signed-off-by: Fullstop000 fullstop1005@gmail.com
What problem does this PR solve?
push down
SignandSqrtWhat is changed and how it works?
SignandSqrtshould be pushed down to TiKVCheck List