expression: implement vectorized evaluation for builtinRowSig
#13321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
wshwsh12 and
XuHuaiyu
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #13321 +/- ##
================================================
- Coverage 80.1903% 80.1621% -0.0283%
================================================
Files 469 469
Lines 112102 111776 -326
================================================
- Hits 89895 89602 -293
+ Misses 15271 15259 -12
+ Partials 6936 6915 -21 |
wshwsh12
reviewed
Nov 10, 2019
qw4990
added
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PCP #12106
What problem does this PR solve?
implement vectorized evaluation for builtinRowSig , for #12106
What is changed and how it works?
just add a panic.