Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: fix fast analyze test #13275

Merged
merged 6 commits into from
Nov 8, 2019
Merged

executor: fix fast analyze test #13275

merged 6 commits into from
Nov 8, 2019

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Nov 8, 2019

What problem does this PR solve? 

[2019-11-07T08:05:54.906Z] ----------------------------------------------------------------------
[2019-11-07T08:05:54.906Z] PANIC: analyze_test.go:454: testFastAnalyze.TestFastAnalyzeRetryRowCount
[2019-11-07T08:05:54.906Z]
[2019-11-07T08:05:54.906Z] ... Panic: this cluster has already split (PC=0xD6BD11)

What is changed and how it works?

Just new a cluster in test to avoid it has been splitted by other tests.

Check List

Tests

  • No code

Code changes

  • None

Side effects

  • None

Related changes

  • None

Release note

  • None

@alivxxx alivxxx requested review from winoros and lzmhhh123 November 8, 2019 03:01
@TennyZhuang TennyZhuang mentioned this pull request Nov 8, 2019
Merged
@zyxbest
Copy link

zyxbest commented Nov 8, 2019

/run-integration-tests

@codecov
Copy link

codecov bot commented Nov 8, 2019 •
edited
Loading

Codecov Report

Merging #13275 into master will decrease coverage by 0.318%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             master    #13275        +/-   ##
===============================================
- Coverage   80.4471%   80.129%   -0.3181%     
===============================================
  Files           469       469                
  Lines        112362    111565       -797     
===============================================
- Hits          90392     89396       -996     
- Misses        15068     15250       +182     
- Partials       6902      6919        +17

lzmhhh123
lzmhhh123 reviewed Nov 8, 2019
View reviewed changes
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzmhhh123 lzmhhh123 added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 8, 2019
jackysp
jackysp approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added the status/can-merge Indicates a PR has been approved by a committer. label Nov 8, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2019

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Nov 8, 2019

@lamxTyler merge failed.

@jackysp jackysp merged commit ab1c939 into pingcap:master Nov 8, 2019
@alivxxx alivxxx deleted the fix-ci branch November 8, 2019 06:15
XiaTianliang pushed a commit to XiaTianliang/tidb that referenced this pull request Dec 21, 2019
@alivxxx @XiaTianliang
executor: fix fast analyze test (pingcap#13275)
33863c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzmhhh123 lzmhhh123 lzmhhh123 left review comments

@jackysp jackysp jackysp approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
component/test status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alivxxx @zyxbest @sre-bot @jackysp @lzmhhh123