bindinfo: support drop specific binding #13245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winoros
added
status/can-merge
alivxxx
added
status/LGT2
Codecov Report
@@ Coverage Diff @@
## master #13245 +/- ##
================================================
- Coverage 80.3624% 80.1895% -0.1729%
================================================
Files 471 471
Lines 114719 113400 -1319
================================================
- Hits 92191 90935 -1256
+ Misses 15459 15396 -63
Partials 7069 7069 |
ngaut
approved these changes
Nov 13, 2019
|
/merge |
|
/run-all-tests |
|
@lamxTyler merge failed. |
|
/run-integration-copr-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
In previous PRs, we support multiply bindings for a single sql. Thus it is necessary to support drop a specific binding.
What is changed and how it works?
usingstatus with their hint, and remove it from cache and store.Check List
Tests
Code changes
Side effects
Related changes
Release note